Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Lint Rules: struct-tag & unexported-return #5533

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

FlamingSaint
Copy link
Member

Which problem is this PR solving?

Description of the changes

  • Enabled struct-tag & unexported-return in revive linter
  • Only use tags on exported fields
  • Converted exported function to have an exported return type

How was this change tested?

  • make lint make test

Checklist

Signed-off-by: FlamingSaint <raghuramkannan400@gmail.com>
@FlamingSaint FlamingSaint requested a review from a team as a code owner June 4, 2024 23:45
@FlamingSaint FlamingSaint requested a review from jkowall June 4, 2024 23:45
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.21%. Comparing base (6b95711) to head (8e19489).

Files Patch % Lines
plugin/storage/grpc/shared/grpc_client.go 93.75% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5533       +/-   ##
===========================================
+ Coverage   54.25%   96.21%   +41.95%     
===========================================
  Files         161      327      +166     
  Lines        8366    16007     +7641     
===========================================
+ Hits         4539    15401    +10862     
+ Misses       3381      431     -2950     
+ Partials      446      175      -271     
Flag Coverage Δ
badger_v1 8.05% <0.00%> (ø)
badger_v2 1.93% <0.00%> (ø)
cassandra-3.x-v1 16.45% <0.00%> (ø)
cassandra-3.x-v2 1.85% <0.00%> (ø)
cassandra-4.x-v1 16.45% <0.00%> (ø)
cassandra-4.x-v2 1.85% <0.00%> (ø)
elasticsearch-7-v1 18.89% <0.00%> (ø)
elasticsearch-8-v1 19.07% <0.00%> (-0.02%) ⬇️
elasticsearch-8-v2 19.07% <0.00%> (ø)
grpc_v1 9.48% <68.75%> (+0.01%) ⬆️
grpc_v2 7.53% <0.00%> (ø)
kafka 9.77% <0.00%> (ø)
opensearch-1-v1 18.94% <0.00%> (+0.01%) ⬆️
opensearch-2-v1 18.94% <0.00%> (ø)
opensearch-2-v2 18.93% <0.00%> (-0.02%) ⬇️
unittests 94.09% <87.50%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label Jun 5, 2024
Signed-off-by: FlamingSaint <raghuramkannan400@gmail.com>
@FlamingSaint FlamingSaint requested a review from yurishkuro June 5, 2024 02:52
@yurishkuro yurishkuro merged commit 14197fe into jaegertracing:main Jun 5, 2024
38 of 39 checks passed
@FlamingSaint FlamingSaint deleted the linter_4 branch June 5, 2024 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:ci Change related to continuous integration / testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants