Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Validate that generated mocks are up to date #5568

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Jun 11, 2024

Which problem is this PR solving?

Description of the changes

  • Add a lint check to the workflow for protobuf

How was this change tested?

  • the step passed in the CI

Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro requested a review from a team as a code owner June 11, 2024 19:54
@yurishkuro yurishkuro requested a review from albertteoh June 11, 2024 19:54
Signed-off-by: Yuri Shkuro <github@ysh.us>
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.20%. Comparing base (03136eb) to head (5404d36).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5568      +/-   ##
==========================================
- Coverage   96.21%   96.20%   -0.02%     
==========================================
  Files         327      327              
  Lines       16006    16006              
==========================================
- Hits        15400    15398       -2     
- Misses        431      432       +1     
- Partials      175      176       +1     
Flag Coverage Δ
badger_v1 8.05% <ø> (ø)
badger_v2 1.93% <ø> (ø)
cassandra-3.x-v1 16.45% <ø> (ø)
cassandra-3.x-v2 1.85% <ø> (ø)
cassandra-4.x-v1 16.45% <ø> (ø)
cassandra-4.x-v2 1.85% <ø> (ø)
elasticsearch-7.x-v1 18.89% <ø> (+0.01%) ⬆️
elasticsearch-8.x-v1 19.09% <ø> (ø)
elasticsearch-8.x-v2 19.09% <ø> (ø)
grpc_v1 9.47% <ø> (-0.02%) ⬇️
grpc_v2 7.53% <ø> (ø)
kafka 9.77% <ø> (ø)
opensearch-1.x-v1 18.94% <ø> (ø)
opensearch-2.x-v1 18.94% <ø> (+0.01%) ⬆️
opensearch-2.x-v2 18.94% <ø> (+0.01%) ⬆️
unittests 94.07% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label Jun 11, 2024
Copy link
Contributor

@jkowall jkowall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yurishkuro yurishkuro merged commit 5bb7cbb into jaegertracing:main Jun 11, 2024
42 of 43 checks passed
@yurishkuro yurishkuro deleted the validate-mocks branch June 11, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:ci Change related to continuous integration / testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants