-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add alternate way to install gotip #5618
Conversation
Signed-off-by: EraKin575 <tejaskumar574@gmail.com>
Signed-off-by: EraKin575 <tejaskumar574@gmail.com>
echo "GOROOT=$(go env GOROOT)" >> $GITHUB_ENV | ||
echo "GOTIP_BIN=$(go env GOPATH)/bin/gotip" >> $GITHUB_ENV | ||
|
||
- name: Fail if Go Tip is not installed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not necessary, we will see if the previous steps fail.
Please demonstrate how it was tested |
Signed-off-by: EraKin575 <tejaskumar574@gmail.com>
I tested it by making a workflow of my own and then running the actions file: https://github.com/EraKin575/test-project |
in your test repo, can you add a step |
Signed-off-by: EraKin575 <tejaskumar574@gmail.com>
go install golang.org/dl/gotip@latest | ||
gotip download | ||
echo "GOROOT=$(go env GOROOT)" >> $GITHUB_ENV | ||
echo "GOTIP_BIN=$(go env GOPATH)/bin/gotip" >> $GITHUB_ENV |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see this in your run https://github.com/EraKin575/test-project/actions/runs/9504391060/job/26196935810#step:7:66
Success. You may now run 'gotip'!
Run echo "Active Go version:"
Active Go version:
go version go1.22.4 linux/amd[64](https://github.com/EraKin575/test-project/actions/runs/9504391060/job/26196935810#step:7:67)
This isn't gotip. And I was expecting that, because you're not setting up env vars the same way as we do in L38-41. For example, you do GOROOT=$(go env GOROOT)
- that's just default Go version, nothing to do with gotip.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note - we could still make it work, I suppose, but then we need to change how the tests are run, e.g. make test GO=gotip
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something like this?
I don't like "designing by screenshots" - you should test it out. This is why we have the final step to print go version
I fixed it. After the manual build step, the gotip toolchain look good: https://github.com/jaegertracing/jaeger/actions/runs/9530915022/job/26271312690#step:5:125
|
Which problem is this PR solving?
#5601
Description of the changes
Fixed gotip workflow according to proposal
How was this change tested?
tested through https://github.com/EraKin575/test-project/actions/runs/9495245139/job/26167103130
Checklist
jaeger
:make lint test
jaeger-ui
:yarn lint
andyarn test