Upgrade Badger v3->Badger v4

[hellspawn679]

Which problem is this PR solving?

• Resolves Upgrade Badger storage to v4 #5611

Description of the changes

• updated flag names that was changes from v3 to v4 causing the test's to fail

How was this change tested?

• test log in the comments

Checklist

• I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
• I have signed all commits
• I have added unit tests for the new functionality
• I have run lint and test steps successfully
  • for jaeger: make lint test
  • for jaeger-ui: yarn lint and yarn test

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.19%. Comparing base (1830148) to head (b2f55ec).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5619      +/-   ##
==========================================
- Coverage   96.20%   96.19%   -0.02%     
==========================================
  Files         327      327              
  Lines       16014    16014              
==========================================
- Hits        15406    15404       -2     
- Misses        432      433       +1     
- Partials      176      177       +1     

Flag	Coverage Δ
badger_v1	8.05% <ø> (ø)
badger_v2	1.93% <ø> (ø)
cassandra-3.x-v1	16.45% <ø> (ø)
cassandra-3.x-v2	1.85% <ø> (ø)
cassandra-4.x-v1	16.45% <ø> (ø)
cassandra-4.x-v2	1.85% <ø> (ø)
elasticsearch-7.x-v1	18.89% <ø> (+0.01%)	⬆️
elasticsearch-8.x-v1	19.07% <ø> (-0.02%)	⬇️
elasticsearch-8.x-v2	19.07% <ø> (-0.02%)	⬇️
grpc_v1	9.48% <ø> (ø)
grpc_v2	7.52% <ø> (-0.02%)	⬇️
kafka	9.77% <ø> (ø)
opensearch-1.x-v1	18.94% <ø> (+0.01%)	⬆️
opensearch-2.x-v1	18.94% <ø> (+0.01%)	⬆️
opensearch-2.x-v2	18.93% <ø> (-0.02%)	⬇️
unittests	94.06% <ø> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[yurishkuro]

Please see testing requirements in the issue.

[yurishkuro]

did you do the backwards compatibility test as described in the issue?

[hellspawn679]

did you do the backwards compatibility test as described in the issue?

how can I do that? Is there a make command that I can use to check it?

[yurishkuro]

how can I do that? Is there a make command that I can use to check it?

no, there's not. You'd need:

• run all-in-one with badger storage from the main branch (or from one of the official released binaries)
  • specify non-ephemeral mode for badger so that it stores data in files on local disk
• run hotrod demo and generate some traces, verify you can load them in the UI. Stop hotrod.
• stop all-in-one and now run it from your branch
• verify you can query & load the same traces in the UI using new version of Badger
• capture a log of commands you ran and post here

[hellspawn679]

steps taken :-

1. [ TERMINAL: 1] git checkout main( current main branch)
2. [ TERMINAL: 1]

mkdir tmp && cd tmp && mkdir key && mkdir span

3. [ TERMINAL: 1 ] taken form here (badger)

export SPAN_STORAGE_TYPE=badger
export BADGER_EPHEMERAL=false
export BADGER_CONSISTENCY=true
export BADGER_DIRECTORY_KEY=/home/kali/go/new/jaeger/tmp/key
export BADGER_DIRECTORY_VALUE=/home/kali/go/new/jaeger/tmp/span
cd ..
make run-all-in-one

4. [ TERMINAL: 2 ] open a new terminal for hotrod and run it using this command opens at localhost:8080

go run ./examples/hotrod/main.go all

5. click on Rachel's Floral design and click on open trace

6. this will create new file in /tmp dir
   

7. [TERMINAL: 1]we can see span process logs in terminal-1
   

8. and this is how UI look like
   

9. stop terminal-1 and terminal-2

10. [TERMINAL: 1]

git checkout badger
make run-all-in-one

11. open http://localhost:16686/search select frontend as service and find trace
    
12. terminal-1 after this
    

[yurishkuro]

that's an awesome log of testing!

[yurishkuro]

Thanks!