Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize build-binaries targets #5924

Merged
merged 6 commits into from
Sep 3, 2024

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Sep 2, 2024

Which problem is this PR solving?

Description of the changes

  • normalize all targets to be build-binaries-$os-$arch
  • change ci-build-binaries.yml workflow to use make echo-platforms for the jobs matrix

How was this change tested?

  • ci

Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label Sep 2, 2024
Signed-off-by: Yuri Shkuro <github@ysh.us>
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.81%. Comparing base (ad6af7a) to head (a9f4956).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5924   +/-   ##
=======================================
  Coverage   96.81%   96.81%           
=======================================
  Files         344      344           
  Lines       16531    16531           
=======================================
  Hits        16004    16004           
  Misses        340      340           
  Partials      187      187           
Flag Coverage Δ
badger_v1 8.05% <ø> (ø)
badger_v2 1.82% <ø> (ø)
cassandra-3.x-v1 16.61% <ø> (ø)
cassandra-3.x-v2 1.75% <ø> (ø)
cassandra-4.x-v1 16.61% <ø> (ø)
cassandra-4.x-v2 1.75% <ø> (ø)
elasticsearch-6.x-v1 18.78% <ø> (ø)
elasticsearch-7.x-v1 18.83% <ø> (ø)
elasticsearch-8.x-v1 19.02% <ø> (ø)
elasticsearch-8.x-v2 1.82% <ø> (ø)
grpc_v1 9.49% <ø> (+0.01%) ⬆️
grpc_v2 7.15% <ø> (ø)
kafka-v1 9.74% <ø> (ø)
kafka-v2 1.82% <ø> (ø)
memory_v2 1.82% <ø> (ø)
opensearch-1.x-v1 18.88% <ø> (ø)
opensearch-2.x-v1 18.88% <ø> (-0.02%) ⬇️
opensearch-2.x-v2 1.81% <ø> (ø)
tailsampling-processor 0.46% <ø> (ø)
unittests 95.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro marked this pull request as ready for review September 2, 2024 19:39
@yurishkuro yurishkuro requested a review from a team as a code owner September 2, 2024 19:39
@yurishkuro yurishkuro requested a review from jkowall September 2, 2024 19:39
@yurishkuro yurishkuro merged commit 3f5e87c into jaegertracing:main Sep 3, 2024
49 checks passed
@yurishkuro yurishkuro deleted the normalize-build-targets branch September 3, 2024 19:56
@yurishkuro yurishkuro mentioned this pull request Sep 14, 2024
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:ci Change related to continuous integration / testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant