Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[adaptive sampling] Clean-up after previous refactoring #5954

Merged
merged 2 commits into from
Sep 7, 2024

Conversation

yurishkuro
Copy link
Member

Which problem is this PR solving?

  • Previous refactoring left the code in a mixed up state

Description of the changes

  • move provider / aggregator / post-aggregator into separate files named accordingly
  • do the same for tests
  • no actual code changes, just moving code around

How was this change tested?

  • CI

Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Copy link
Collaborator

@mahadzaryab1 mahadzaryab1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

codecov bot commented Sep 7, 2024

Codecov Report

Attention: Patch coverage is 86.95652% with 9 lines in your changes missing coverage. Please review.

Project coverage is 96.80%. Comparing base (88a0319) to head (c3dcaac).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...gin/sampling/strategyprovider/adaptive/provider.go 86.95% 8 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5954       +/-   ##
===========================================
+ Coverage   51.44%   96.80%   +45.36%     
===========================================
  Files         176      345      +169     
  Lines        8869    16518     +7649     
===========================================
+ Hits         4563    15991    +11428     
+ Misses       3863      340     -3523     
+ Partials      443      187      -256     
Flag Coverage Δ
badger_v1 8.03% <ø> (ø)
badger_v2 1.82% <ø> (ø)
cassandra-3.x-v1 16.62% <ø> (ø)
cassandra-3.x-v2 1.75% <ø> (ø)
cassandra-4.x-v1 16.62% <ø> (ø)
cassandra-4.x-v2 1.75% <ø> (ø)
elasticsearch-6.x-v1 18.79% <ø> (+0.01%) ⬆️
elasticsearch-7.x-v1 18.85% <ø> (ø)
elasticsearch-8.x-v1 19.03% <ø> (-0.02%) ⬇️
elasticsearch-8.x-v2 1.81% <ø> (ø)
grpc_v1 9.48% <ø> (-0.02%) ⬇️
grpc_v2 7.16% <ø> (ø)
kafka-v1 9.74% <ø> (ø)
kafka-v2 1.82% <ø> (ø)
memory_v2 1.82% <ø> (ø)
opensearch-1.x-v1 18.89% <ø> (-0.02%) ⬇️
opensearch-2.x-v1 18.90% <ø> (+0.01%) ⬆️
opensearch-2.x-v2 1.81% <ø> (ø)
tailsampling-processor 0.46% <ø> (ø)
unittests 95.28% <86.95%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro merged commit 9bdd368 into jaegertracing:main Sep 7, 2024
48 of 49 checks passed
@yurishkuro yurishkuro deleted the adaptive-cleanup2 branch September 7, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants