Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] disable fail fast behaviour for ci workflows #6052

Merged
merged 6 commits into from
Oct 5, 2024

Conversation

mahadzaryab1
Copy link
Collaborator

@mahadzaryab1 mahadzaryab1 commented Oct 4, 2024

Which problem is this PR solving?

Description of the changes

  • Added the fail-fast flag to all workflow files that use a matrix strategy to avoid other jobs from aborting due to a single job failing (read more about the fail-fast flag here).

How was this change tested?

Introduced a failure in the Cassandra E2E Test. This test failed fast and prevented other workflows in the matrix from running.
Screenshot 2024-10-04 at 6 29 01 PM
After adding fail-fast: false to the workflow file, the other tests were still able to complete.
Screenshot 2024-10-04 at 6 37 52 PM

Checklist

Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
@mahadzaryab1 mahadzaryab1 changed the title [WIP] [ci] disable fail fast behaviour for ci [WIP] [ci] disable fail fast behaviour for ci workflows Oct 4, 2024
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.91%. Comparing base (36291a7) to head (020ac4d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6052   +/-   ##
=======================================
  Coverage   96.91%   96.91%           
=======================================
  Files         349      349           
  Lines       16587    16587           
=======================================
  Hits        16076    16076           
  Misses        328      328           
  Partials      183      183           
Flag Coverage Δ
badger_v1 8.00% <ø> (ø)
badger_v2 1.82% <ø> (ø)
cassandra-4.x-v1 15.77% <ø> (ø)
cassandra-4.x-v2 1.74% <ø> (ø)
cassandra-5.x-v1 15.77% <ø> (ø)
cassandra-5.x-v2 1.74% <ø> (ø)
elasticsearch-6.x-v1 18.71% <ø> (ø)
elasticsearch-7.x-v1 18.78% <ø> (+0.01%) ⬆️
elasticsearch-8.x-v1 18.97% <ø> (ø)
elasticsearch-8.x-v2 1.81% <ø> (ø)
grpc_v1 9.38% <ø> (ø)
grpc_v2 7.12% <ø> (-0.02%) ⬇️
kafka-v1 9.71% <ø> (ø)
kafka-v2 1.82% <ø> (ø)
memory_v2 1.82% <ø> (ø)
opensearch-1.x-v1 18.81% <ø> (ø)
opensearch-2.x-v1 18.81% <ø> (-0.02%) ⬇️
opensearch-2.x-v2 1.81% <ø> (ø)
tailsampling-processor 0.46% <ø> (ø)
unittests 95.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mahadzaryab1 mahadzaryab1 changed the title [WIP] [ci] disable fail fast behaviour for ci workflows [ci] disable fail fast behaviour for ci workflows Oct 4, 2024
@mahadzaryab1 mahadzaryab1 marked this pull request as ready for review October 4, 2024 22:38
@mahadzaryab1 mahadzaryab1 requested a review from a team as a code owner October 4, 2024 22:38
@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label Oct 5, 2024
@yurishkuro yurishkuro merged commit b4763f0 into jaegertracing:main Oct 5, 2024
49 of 50 checks passed
@mahadzaryab1 mahadzaryab1 deleted the remove-fail-fast branch October 31, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:ci Change related to continuous integration / testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not fail all CI matrix jobs if one of them fails
2 participants