-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] disable fail fast behaviour for ci workflows #6052
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
mahadzaryab1
changed the title
[WIP] [ci] disable fail fast behaviour for ci
[WIP] [ci] disable fail fast behaviour for ci workflows
Oct 4, 2024
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6052 +/- ##
=======================================
Coverage 96.91% 96.91%
=======================================
Files 349 349
Lines 16587 16587
=======================================
Hits 16076 16076
Misses 328 328
Partials 183 183
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mahadzaryab1
changed the title
[WIP] [ci] disable fail fast behaviour for ci workflows
[ci] disable fail fast behaviour for ci workflows
Oct 4, 2024
yurishkuro
reviewed
Oct 5, 2024
yurishkuro
added
the
changelog:ci
Change related to continuous integration / testing
label
Oct 5, 2024
yurishkuro
approved these changes
Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
fail-fast
flag to all workflow files that use a matrix strategy to avoid other jobs from aborting due to a single job failing (read more about the fail-fast flag here).How was this change tested?
Introduced a failure in the Cassandra E2E Test. This test failed fast and prevented other workflows in the matrix from running.
After adding
fail-fast: false
to the workflow file, the other tests were still able to complete.Checklist
jaeger
:make lint test
jaeger-ui
:yarn lint
andyarn test