Support dependencies v2 in c* #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
|
@black-adder could you please review this? I will merge it in order to fix CI in the operator. |
pavolloffay
commented
Feb 21, 2019
| return zonedDateTime.toInstant().toEpochMilli(); | ||
| } | ||
|
|
||
| public Long getTsBucket() { |
There was a problem hiding this comment.
@black-adder is this ok?
There was a problem hiding this comment.
we should truncate the time as well, ala .toInstant().truncatedTo(ChronoUnit.DAYS).toEpochMilli()
pavolloffay
commented
Feb 21, 2019
| @@ -66,6 +66,13 @@ public boolean equals(Object o) { | |||
| && this.callCount == that.callCount; | |||
| } | |||
|
|
|||
| public String getSource() { | |||
| return "jaeger"; | |||
There was a problem hiding this comment.
@black-adder is this ok?
black-adder
reviewed
Feb 21, 2019
| return zonedDateTime.toInstant().toEpochMilli(); | ||
| } | ||
|
|
||
| public Long getTsBucket() { |
There was a problem hiding this comment.
we should truncate the time as well, ala .toInstant().truncatedTo(ChronoUnit.DAYS).toEpochMilli()
| @@ -66,6 +66,13 @@ public boolean equals(Object o) { | |||
| && this.callCount == that.callCount; | |||
| } | |||
|
|
|||
| public String getSource() { | |||
| return "jaeger"; | |||
| } | ||
|
|
||
| public void setSource(String source) { | ||
| } |
Sasasu
reviewed
Jul 25, 2019
| .saveToCassandra(); | ||
| String table = dependenciesTable(sc); | ||
| log.info("Storing dependencies into {}", table); | ||
| if (table == "dependencies_v2") { |
There was a problem hiding this comment.
I think using equals() is better.
use == to compare strings, in this case, it works but makes confusing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #58