-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: from simple keybindings to commands like in vim #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dot-viewer
features were previously triggered by simple keybindings (i.e.,s
forsubgraph
,f
forfilter
, ...).Since it is quite burdensome for users to learn and memorize the keybindings, in this PR,
dot-viewer
triggers its features through commands.Via
:
, users may enter command mode and enter commands:neighbors
,filter
,subgraph
,help
,export
,xdot
.Several changes were made to the source code as well.
1. Changed definition of
Mode
.Mode
was previously defined as,It is now simplified as,
This allowed simplified function arguments in the
ui
module as well. There is no such strange function signatures as,where
mmode
is actually a clone ofapp
's field.2. Semantics of
search
andfilter
.Like in vim, users can
search
for nodes using keywords, and after hittingenter
, users may navigate through the matched nodes withn/N
keys.So there is no separate screen showing search matches in this version.
Also,
filter
previously filtered nodes with a given prefix. However, such function is already supported bysubgraph
. Thus,filter
now creates a filteredView
based on search matches.3. Semantics of
neighbors
Previously,
neighbors
produced a dot file with0-9
keybindings.In this version,
neighbors n
command creates a newView
instead. So it supports any integern
larger than 9.4. Options in
export
andxdot
Now users may optionally provide filename that he or she wants to
export
to, or launchxdot
from.