Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#210 group ownership change notification #10

Merged
merged 3 commits into from
Sep 1, 2022

Conversation

LaimeJesus
Copy link

related #210

Description

This PR adds the following changes:

  • Fixes issue with the GroupOwnerChangeEvent schema,
    • it was using Safe address when there are some cases that the owner address used is not a safe
  • Adds notifications now are only created for existing safe accounts
  • Fixes type 'GROUP_OWNER_CHANGE' was not added in the NotificationType enum, so it was not possible to filter by those notifications

How to test

old SG: https://thegraph.com/hosted-service/subgraph/laimejesus/shisus-crc-local

new SG: https://thegraph.com/hosted-service/subgraph/laimejesus/circles-local

After fix:

image

…se the old/new address could not be a safe account
notifications for group owner change are only created when the new/old owner is a safe account
@LaimeJesus LaimeJesus requested a review from patitonar August 31, 2022 13:47
@LaimeJesus LaimeJesus changed the base branch from main to dev September 1, 2022 16:55
@LaimeJesus LaimeJesus merged commit 7610d6c into dev Sep 1, 2022
@LaimeJesus LaimeJesus deleted the feature/#210-group-ownership-change-notification branch September 1, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants