Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java 9 support #21

Merged
merged 8 commits into from
Jan 15, 2020
Merged

Java 9 support #21

merged 8 commits into from
Jan 15, 2020

Conversation

rleigh-codelibre
Copy link
Contributor

This PR depends upon jai-imageio/jai-imageio-core#41 and it must be built and installed before testing this PR. It will also require releasing and the dependency version bumping in order for Travis to go green.

This PR contains the fixes necessary to build and test with Java 9. With this PR, you can run:

MAVEN_OPTS="--add-opens java.base/java.lang=ALL-UNNAMED --add-modules java.activation" mvn install

(the MAVEN_OPTS is currently needed to run under Java 9, and should hopefully go away once it's updated as well.)

@Jugen
Copy link
Contributor

Jugen commented Apr 11, 2018

If this PR gets updated / refreshed wouldn't that maybe solve the Travis fails ?

@rleigh-codelibre
Copy link
Contributor Author

@Jugen Yes, it should do. It's depends upon jai-imageio having a public release so that there's a version containing the fix which we can fetch.

@stain is 1.4.0 expected to be deployed to maven central soon?

@Jugen
Copy link
Contributor

Jugen commented Apr 16, 2018

@rleigh-codelibre jai-imageio 1.4.0 now has a public release on maven :-)

@Jugen
Copy link
Contributor

Jugen commented Apr 24, 2018

@rleigh-codelibre Hi Roger could you please update this PR, thanks.

@rleigh-codelibre
Copy link
Contributor Author

rleigh-codelibre commented Apr 24, 2018

@Jugen I've pushed the updates. Could you possibly give it a try?

@Jugen
Copy link
Contributor

Jugen commented Apr 24, 2018

Thanks a lot Roger :-)

@stain Hi Stian can this be merged please, so that the other PR's that depend on this pass.

@rleigh-codelibre
Copy link
Contributor Author

See also jai-imageio/jai-imageio-core#53 for the latest maven updates also added here.

@Jugen
Copy link
Contributor

Jugen commented May 16, 2018

@stain Can this be merged please ?

@stain stain merged commit d8669ae into jai-imageio:master Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants