Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate old authentication tck sources from jakartaee-tck #167

Merged
merged 6 commits into from
Jun 14, 2022

Conversation

alwin-joseph
Copy link
Contributor

@alwin-joseph alwin-joseph commented Jun 3, 2022

This PR migrates the authentication TCK sources from platform TCK https://github.com/eclipse-ee4j/jakartaee-tck , so the authentication TCK tests are in one place now.

Test execution commands :

  • To run the TCK in platform mode , full profile : mvn clean install -Pplatform (68 tests)
  • To run the TCK in platform mode, web profile : mvn clean install -Pplatform,web (61 tests)
  • To run the TCK in standalone mode (default) : mvn clean install (106 tests)

Pending:

  • The old tck contents need to be integrated with the main tck bundle.
  • The userguide may be updated with the old tck run instructions.
  • The signature test need to be migrated which can be done in separate PR (not required for platform run).

CC @arjantijms @scottmarlow @gurunrao

@alwin-joseph
Copy link
Contributor Author

Hi @arjantijms Can you please review, merge this and help provide a service release for authentication tck with this changes so that the same TCK can be used for Platform compatibility.

@scottmarlow
Copy link

Seems like our option is either accept this change and test GlassFish 7 against it or test GlassFish 7 against the (Platform TCK staged) TCK. Which ever way we proceed, we need to publish the old Authentication TCK.

Also, the New Authentication TCK needs a change to be able to run the old Authentication TCK or we need to determine a way for users to run the old Authentication TCK.

@arjantijms
Copy link
Contributor

Can you please review, merge this and help provide a service release for authentication tck

Yes, I'll look at that. I was (and am) much tied up with the CDI and Concurrency work, getting GF 7 to pass that, but this is definitely on the list too.

@arjantijms arjantijms added the TCK label Jun 14, 2022
@arjantijms arjantijms merged commit 7af11a8 into jakartaee:master Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants