Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed example Wildfly project for running the lang model TCK #394

Merged

Conversation

OndroMih
Copy link
Contributor

The example was designed to run with a plain Weld in Java SE. I added an option to run it against WildFly and fixed the test to pass on WildFly with similar fixes we applied for GlassFish.

I also updated the README to explain how to run the Language Model TCK.

Signed-off-by:Ondro Mihalyi <mihalyi@omnifish.ee>
Copy link
Contributor

@manovotn manovotn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wildfly8 in the name of package should be changed to just wildfly (FTR the actual version will be 27 but it is just better without version for future iterations).

Also I didn't test the setup locally but I assume you did.

Signed-off-by:Ondro Mihalyi <mihalyi@omnifish.ee>
@OndroMih
Copy link
Contributor Author

Renamed wildfly8 to wildfly.

Signed-off-by:Ondro Mihalyi <mihalyi@omnifish.ee>
Copy link
Contributor

@manovotn manovotn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM although I haven't verified it locally in its latest iteration.

@manovotn manovotn merged commit 7310745 into jakartaee:master Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants