Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language model and build compatible extensions API clarifications #560

Merged
merged 1 commit into from
Nov 22, 2021

Conversation

Ladicek
Copy link
Contributor

@Ladicek Ladicek commented Nov 22, 2021

  • renamed BeanInfo.getName() to name() for consistency
  • renamed ObserverInfo.observedType() to eventType() for clarity
  • added SyntheticComponents.addObserver(Type) to allow registering
    synthetic observers of parameterized types
  • changed WildcardType representation to always include an upper
    bound; the ? extends Object type is no longer represented as ?
    because the upper bound may be annotated
  • improved specification of AnnotationTarget, especially around
    repeatable annotation types
  • improved specification of ClassInfo and MethodInfo, especially
    around implicit declarations and abstract classes/methods

- renamed `BeanInfo.getName()` to `name()` for consistency
- renamed `ObserverInfo.observedType()` to `eventType()` for clarity
- added `SyntheticComponents.addObserver(Type)` to allow registering
  synthetic observers of parameterized types
- changed `WildcardType` representation to always include an upper
  bound; the `? extends Object` type is no longer represented as `?`
  because the upper bound may be annotated
- improved specification of `AnnotationTarget`, especially around
  repeatable annotation types
- improved specification of `ClassInfo` and `MethodInfo`, especially
  around implicit declarations and `abstract` classes/methods
@Ladicek Ladicek requested a review from graemerocher November 22, 2021 16:27
@Ladicek
Copy link
Contributor Author

Ladicek commented Nov 22, 2021

These changes are motivated by my TCK work. It should be the last batch of changes, at least to the language model, whose TCK should now be complete (jakartaee/cdi-tck#310). I'll continue working on the build compatible extensions tests, which may motivate some changes in the extension API, but hopefully minimal.

@Ladicek Ladicek merged commit 8b6ea57 into jakartaee:master Nov 22, 2021
@Ladicek Ladicek deleted the clarifications branch November 22, 2021 16:34
@Ladicek Ladicek added Lite Related to CDI Lite lite-extension-api Issues related to CDI Lite extension API proposal labels Nov 22, 2021
@Ladicek
Copy link
Contributor Author

Ladicek commented Nov 22, 2021

Actually I just realized that the commit message is wrong, the WildcardType does not always include an upper bound. It's that it always includes some bound -- either lower or upper. The unbounded wildcard is no longer represented as without bounds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Lite Related to CDI Lite lite-extension-api Issues related to CDI Lite extension API proposal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants