Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change parameter type of SkipIfPortableExtensionPresent from String to Class #586

Merged
merged 1 commit into from
Jan 5, 2022
Merged

Change parameter type of SkipIfPortableExtensionPresent from String to Class #586

merged 1 commit into from
Jan 5, 2022

Conversation

manovotn
Copy link
Contributor

@manovotn manovotn commented Jan 5, 2022

Fixes #585

@manovotn manovotn requested a review from Ladicek January 5, 2022 09:51
Ladicek
Ladicek approved these changes Jan 5, 2022
View reviewed changes
Copy link
Contributor

@Ladicek Ladicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I originally thought it would be just Class<?>, but this is even better, thanks!

@Ladicek Ladicek added Lite Related to CDI Lite lite-extension-api Issues related to CDI Lite extension API proposal labels Jan 5, 2022
@Ladicek Ladicek merged commit 4507fa8 into jakartaee:master Jan 5, 2022
@manovotn manovotn deleted the issue585 branch January 5, 2022 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ladicek Ladicek Ladicek approved these changes

Assignees
No one assigned
Labels
Lite Related to CDI Lite lite-extension-api Issues related to CDI Lite extension API proposal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The parameter of @SkipIfPortableExtensionPresent should have type Class
2 participants
@manovotn @Ladicek