Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix guards against repeated external sets of SPI implementations #690

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

Ladicek
Copy link
Contributor

@Ladicek Ladicek commented Aug 30, 2023

We previously [1] added code to guard against repeated calls to these SPIs:

  • BuildServicesResolver.setBuildServices()
  • CDI.setCDIProvider()

The guards are unfortunately incorrect. This commit fixes them.

[1] 82ec5d7

We previously [1] added code to guard against repeated calls to these SPIs:

- `BuildServicesResolver.setBuildServices()`
- `CDI.setCDIProvider()`

The guards are unfortunately incorrect. This commit fixes them.

[1] jakartaee@82ec5d7
@Ladicek Ladicek added this to the CDI 4.1 milestone Aug 30, 2023
@Ladicek Ladicek requested a review from manovotn August 30, 2023 12:37
@Ladicek
Copy link
Contributor Author

Ladicek commented Aug 30, 2023

Fortunately, the code that we previously added did not make it into any release, it's only in the master branch now. So we can just fix it.

@mkouba
Copy link
Contributor

mkouba commented Aug 30, 2023

Fortunately, the code that we previously added did not make it into any release, it's only in the master branch now. So we can just fix it.

Good catch! 👍

Copy link
Contributor

@manovotn manovotn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing this!

@manovotn manovotn merged commit 8ead70b into jakartaee:master Aug 30, 2023
@Ladicek Ladicek deleted the fix-repeated-spi-set-guards branch August 30, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants