Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mention of context activation from AfterDeploymentValidation event #705

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

manovotn
Copy link
Contributor

Fixes #454

This doesn't change functionality, just removes a bit of text potentially causing confusion.
While it is true that contexts aren't activated before this event, there is nothing preventing impls from activating them within this event. In fact, BM#getReference explicitly allows to resolve all beans at this point which means you have to be able to activate contexts anyway.

@manovotn manovotn added this to the CDI 4.1 milestone Nov 28, 2023
@manovotn manovotn requested review from ljnelson and Ladicek November 28, 2023 13:07
@manovotn manovotn merged commit 38265cb into jakartaee:main Nov 29, 2023
2 checks passed
@manovotn manovotn deleted the issue454 branch November 29, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants