Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add entry for jdk 21 into Github Actions building matrix #707

Conversation

bmscomp
Copy link
Contributor

@bmscomp bmscomp commented Nov 28, 2023

The main purpose of this pull request is to add an entry for building the project using JDK 21 with and update of github actions tools for checkout and build project

@manovotn
Copy link
Contributor

This is already updated in main via the PR I mentioned in your previous commit.
See https://github.com/jakartaee/cdi/blob/main/.github/workflows/ci-actions.yml#L14

@manovotn manovotn closed this Nov 28, 2023
@bmscomp
Copy link
Contributor Author

bmscomp commented Nov 28, 2023

@starksm64 @manovotn @Ladicek I could not imagine that part of my previous pull request is copied on new one and those are closed, I think it's better to give a chance to new contributor to update fixe, adjust his pull request and give him a chance to learn more about the project rather then copy part of his pull request merge it and close his original ones

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants