- Cleanup in prep for the 4.1.0-M1 release #710
Conversation
starksm64
commented
Nov 30, 2023
starksm64
commented
- Update to use latest parent pom for common plugin versions and sbom generation
- Use parent pom version where appropriate
- Update other plugin versions
- Restore source attachment which was lost somewhere
- Update copyright dates
+ Update to use latest parent pom for common plugin versions and sbom generation + Use parent pom version where appropriate + Update other plugin versions + Restore source attachment which was lost somewhere + Update copyright dates Signed-off-by: Scott M Stark <starksm64@gmail.com>
Signed-off-by: Scott M Stark <starksm64@gmail.com>
… page Signed-off-by: Scott M Stark <starksm64@gmail.com>
Signed-off-by: Scott M Stark <starksm64@gmail.com>
api/pom.xml
Outdated
| @@ -124,10 +124,11 @@ | |||
|
|
|||
|
|
|||
| <properties> | |||
| <annotation.api.version>2.1.0</annotation.api.version> | |||
| <annotation.api.version>3.0.0-M1</annotation.api.version> | |||
| <atinject.api.version>2.0.1</atinject.api.version> | |||
| <uel.api.version>5.0.0</uel.api.version> | |||
| <interceptor.api.version>2.1.0</interceptor.api.version> | |||
There was a problem hiding this comment.
2.2.0-RC1 here?
Or, if you have the powers, it would be great to have jakartaee/interceptors#103 merged and another RC / milestone / whatever released.
There was a problem hiding this comment.
+1, that would be great. I tried bumping that PR months ago but didn't get response.
There was a problem hiding this comment.
The interceptors PR has been merged for the next release. The annotation.api.version should be 3.0.0-M1for EE 11.
There was a problem hiding this comment.
I went to do a release of interceptors and see there already is a 2.2.0-M1, so I guess you were talking about 2.2.0-RC1 being for interceptors. If this has been release we will have to stick with that, otherwise I'll redo it. Right now CDI does not build with that version so it does not appear to have made it to central, but it could be syncing.
There was a problem hiding this comment.
Thanks!
I was thinking we should bump the interceptor.api.version here, too. I don't know what would be the correct version string of the next Interceptors release (2.2.0-M1 or 2.2.0-RC2 I guess), but I'm pretty sure we'll need that too.
There was a problem hiding this comment.
@Emily-Jiang Yes, there is some problem with the check plugin that needs to be update. We also need to update the parent pom version. Do you want me to look at getting the release out?
There was a problem hiding this comment.
See this PR, jakartaee/interceptors#105
There was a problem hiding this comment.
Thanks @starksm64 ! I merged your PR and kicked off the Interceptor build 2.2.0-M1. It was done successfully. However, I could not push it out to maven central as I am unable to see the stage repo id from Sonatype. I need to request an access for that. Can you please release it to maven central and then you can update the dependency to that spec in CDI pom.xml?
There was a problem hiding this comment.
@Emily-Jiang Ok, doing it now
There was a problem hiding this comment.
It built for me locally as I see the 2.2.0-M1 in https://repo1.maven.org/maven2/jakarta/interceptor/jakarta.interceptor-api/. We will see if the build CI is seeing the update as well.
Signed-off-by: Scott M Stark <starksm64@gmail.com>
Signed-off-by: Scott M Stark <starksm64@gmail.com>
