-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document and add copyright headers #756
Conversation
I think we really should get rid of |
True, +1 for removing that; I didn't even know it's there, else I'd have removed that as part of the PR you linked :) |
I was a bit unsure whether the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
CONTRIBUTING.adoc
When reviewing, please particularly check that I haven't added a copyright header to something that shouldn't have one. The areas I wasn't sure about were:
docs
directory which builds https://jakartaee.github.io/cdi/.github
directryide-support
andjboss_community_formatter.xml
- I don't know how these were developed, they may have come form another project and probably started from the defaults of the the software that creates them?I haven't changed any headers on existing files and I've used the format that includes the original author's name since some of the files pre-date involvement with the Eclipse Foundation.
Script used to generate headers
It's a bit rough, some files needed fixed up by hand, particularly XML ones since the
<?xml
line must be first if present.Fixes #741