Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removing duplicate EJB definition classes #218

Merged
merged 1 commit into from
Jun 18, 2022
Merged

removing duplicate EJB definition classes #218

merged 1 commit into from
Jun 18, 2022

Conversation

breakponchito
Copy link
Contributor

This is to remove duplicate EJB definition classes from the arquillian deployment configuration

njr-11
njr-11 approved these changes May 2, 2022
View reviewed changes
Copy link
Contributor

@njr-11 njr-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this. Does it cause any error when you run the TCK (it didn't for me) or is it just cleanup? Given that the spec is already under ballot, I'd like to target this for vNext of the spec.

@njr-11 njr-11 added this to the 3.1 milestone May 2, 2022
@breakponchito
Copy link
Contributor Author

yes, this is causing a jndi binding issue when having duplicate version of the EJB classes on both configuration archives

@njr-11
Copy link
Contributor

njr-11 commented May 2, 2022 •
edited
Loading

yes, this is causing a jndi binding issue when having duplicate version of the EJB classes on both configuration archives

In that case, it will need to be made into a TCK challenge to get the failing tests excluded from EE 10. See "Filing a Challenge" under https://jakarta.ee/committees/specification/tckprocess/

@breakponchito
Copy link
Contributor Author

Ok Nathan, I'll review as soon as possible

@aubi aubi deleted the remove-duplicate-ejb-classes branch May 12, 2022 14:16
@aubi aubi mentioned this pull request May 13, 2022
Merged
@smillidge smillidge added the TCK label May 19, 2022
@aubi aubi mentioned this pull request May 20, 2022
Closed
@smillidge smillidge merged commit 201e549 into jakartaee:master Jun 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njr-11 njr-11 njr-11 approved these changes

Assignees
No one assigned
Labels
TCK
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@breakponchito @njr-11 @smillidge