TCK: Standardize test clients and context lookups #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aubi
reviewed
Jun 28, 2023
| @@ -42,6 +44,9 @@ public static WebArchive createDeployment() { | |||
| return ShrinkWrap.create(WebArchive.class) | |||
| .addPackages(true, ContextServiceTests.class.getPackage()); | |||
| } | |||
|
|
|||
| @Resource(lookup = TestConstants.DefaultContextService) | |||
There was a problem hiding this comment.
Do we need to explicitly specify default values? I would use the lookup only when needed.
There was a problem hiding this comment.
In some cases, yes.
This resource is injected by the Arquillian enricher and not the application server itself.
mswatosh
approved these changes
Jul 6, 2023
|
I'll leave this PR open for a bit longer to see if there are any review comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue #269
There were a number of TCK test classes that just call tests within a servlet and nothing more.
In these cases, the test class can act both as a client and a servlet so we don't need all the extra boilerplate code.
Additionally, I standardized the use of
@Resourceand InitalContext.doLookup().