Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize the TCK for future maintainability #309

Merged
merged 6 commits into from
Jul 14, 2023

Conversation

KyleAure
Copy link
Contributor

This is a rather large PR that will help us modernize the TCK for future development and accomplishes the following tasks:

  1. Fixes JDK warnings about generic misusage to clear up the IDE environment
  2. Fixes some package names to follow the standard of the rest of the TCK
  3. Removes bespoke callable/runnable tasks that could be substituted for existing common tasks.
  4. Removes the TestUtil class in favor of more specialized classes that make more sense.
  5. Standardize the use of Duration instead of Long to avoid confusion on what uses milliseconds vs. seconds vs. minutes
  6. Refactor assertions to use assertThrows and assertTimeout
  7. Creates a common package for Transaction tests to remove duplicate code
  8. Removes duplicated tests

Probably should have broken this down into smaller PRs but once I started refactoring one thing everything just started falling into place.
Most of these are all separated out into individual commits for review.

@KyleAure KyleAure added the TCK label Jul 12, 2023
@KyleAure KyleAure self-assigned this Jul 12, 2023
Copy link
Contributor

@arjantijms arjantijms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, didn't check everything, but broadly looks fine.

@KyleAure KyleAure merged commit a9bf4ac into jakartaee:main Jul 14, 2023
2 checks passed
@KyleAure KyleAure deleted the 269-modernize-tck branch July 14, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants