Remove override via application.xml test #428
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When writing tests for
qualifier
I wrote a test that is invalid.Based on the Concurrency javadoc:
concurrency/api/src/main/java/jakarta/enterprise/concurrent/ManagedExecutorDefinition.java
Lines 93 to 99 in 357c45e
I assumed that meant that a deployment descriptor in
application.xml
would merge/override values defined on the class annotation@ManagedThreadFactoryDefinition
.This was the wrong assumption based on the platform spec:
https://github.com/jakartaee/platform/blob/29bf7cc3266097d3b68d8d849ccd01eefbae9a1b/specification/src/main/asciidoc/platform/ApplicationAssemblyDeployment.adoc?plain=1#L1069-L1081
Which seems to indicate that
metadata-complete
is what defines whether or not merging should happen between deployment descriptor and annotation defined resources.It wouldn't make sense for application.xml to have a metadata-complete attribute since there are no packages/classes directly in the application EAR (there are only modules and libraries).
The schema backs this up by not having a metadata-complete attribute for application.xml and therefore we can infer that any resource defined in application.xml is complete and will never be merged, making this test invalid.