Help automate specification project release review #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mswatosh
reviewed
Apr 19, 2024
| @@ -161,7 +167,7 @@ | |||
| <description>Jakarta Concurrency API documentation</description> | |||
| <doctitle>Jakarta Concurrency API documentation</doctitle> | |||
| <windowtitle>Jakarta Concurrency API documentation</windowtitle> | |||
| <header><![CDATA[<br>Jakarta Concurrency API v${project.version}]]></header> | |||
| <header><![CDATA[<br>Jakarta Concurrency API v${spec.specification.version}]]></header> | |||
There was a problem hiding this comment.
Should this just be spec.version?
There was a problem hiding this comment.
It could be either. The plugin before this does some verification between spec/project versions and spits out a set of properties that can be used elsewhere in the pom.xml. So I used the verified value here.
pzygielo
reviewed
Apr 19, 2024
pzygielo
reviewed
Apr 19, 2024
KyleAure
force-pushed
the
fix-spec-generation
branch
from
e5b7712
to
2156a7a
Compare
pzygielo
reviewed
Apr 19, 2024
KyleAure
force-pushed
the
fix-spec-generation
branch
from
2156a7a
to
f861d2a
Compare
mswatosh
approved these changes
Apr 24, 2024
|
Ready to merge once 3.1.0 is published (don't want to introduce changes to the spec pom if we need to do a rebuild) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gathers all materials needed for specification project release review and packages them