Skip handling test requirements for bdist_conda
#50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need to handle the case of `bdist_conda` specially with respect to test requirements. We already add `nose` as a test requirement regardless of whether `bdist_conda` is specified. So this is merely redundant code that can be dropped.
jakirkham
force-pushed
the
drop_bdist_conda_test_reqs
branch
from
88ea19a
to
5ec146a
Compare
jakirkham
changed the title
bdist_conda
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need to handle the case of
bdist_condaspecially with respect to test requirements. We already addnoseas a test requirement regardless of whetherbdist_condais specified. So this is merely redundant code that can be dropped.