Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to bevy 0.13, egui 0.26, and more #185

Merged
merged 4 commits into from
Feb 21, 2024
Merged

Update to bevy 0.13, egui 0.26, and more #185

merged 4 commits into from
Feb 21, 2024

Conversation

Aztro-dev
Copy link
Contributor

No description provided.

@mosure mosure mentioned this pull request Feb 20, 2024
Merged
This was referenced Feb 20, 2024
Merged
Merged
RobWalt
RobWalt approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@RobWalt RobWalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor comments on the code. It should work fine anyways and I don't want to block this PR as it's important for the eco-system, so feel free to ignore

crates/bevy-inspector-egui/src/bevy_inspector/mod.rs Show resolved Hide resolved
crates/bevy-inspector-egui/src/inspector_egui_impls/bevy_impls.rs Outdated Show resolved Hide resolved
crates/bevy-inspector-egui/src/quick.rs Outdated Show resolved Hide resolved
crates/bevy-inspector-egui/src/quick.rs Outdated Show resolved Hide resolved
This was referenced Feb 20, 2024
Closed
Closed
@EmiOnGit EmiOnGit mentioned this pull request Feb 20, 2024
Merged
@theshortcut
Copy link

Agreed with @RobWalt that this would be great to get out, some of the examples still need some updates I think in particular due to the exposure changes a lot of the example scenes probably need some lighting updates. For example the egui_dock example now looks like this:

image

Tweaking the PointLight intensity from 25.0 to 12000.0 and the DirectionalLight illuminance down to 2000.0 gets the scene looking a little more like it used to though the ceiling emissive plane still looks very wrong:

image

@Aztro-dev
Copy link
Contributor Author

Aztro-dev commented Feb 20, 2024 •
edited
Loading

The only example I have yet to fix (that I know of) is the egui-dock example, as I get a fatal error on my Laptop (M2 MacBook Air), but once I get home from school I can devote more time to fixing the example. If anyone can suggest a change then I could add it to the pull request.

I will also later make an issue for the problem that I am having, but that will also happen when I get home.

@kaosat-dev
Copy link

@theshortcut I believe emissive materials are broken in V0.13, based on my migration work today . Currently working on a minimalist example to create an issue on the Bevy repo

@Aztro-dev
Copy link
Contributor Author

I updated the final example (egui_dock) to be more like the original, but I encourage others to compare the differences between the original and new examples.

@RobWalt RobWalt mentioned this pull request Feb 21, 2024
Merged
4 tasks
@Aztro-dev
Copy link
Contributor Author

Should we just merge? I think the examples are fine, and a lot of crates are waiting for this PR to go through.

@jakobhellermann
Copy link
Owner

I was just about to take a look at the PR. Looks good to me, and thanks for doing the update ❤️

@jakobhellermann jakobhellermann merged commit 26accf6 into jakobhellermann:main Feb 21, 2024
1 check passed
ManevilleF added a commit to ManevilleF/hexx that referenced this pull request Feb 21, 2024
@ManevilleF
Bevy 0.13 (#149)
2d0a5c0 
Blocked on:
* [x] mvlabat/bevy_egui#236
* [x] jakobhellermann/bevy-inspector-egui#185
ManevilleF added a commit to ManevilleF/bevy_silk that referenced this pull request Feb 22, 2024
@ManevilleF
Bevy 0.13 (#24)
2b47288 
Blocking:
* [x] dimforge/bevy_rapier#479
* [x] Jondolf/avian#315
* [x] mvlabat/bevy_egui#236
* [x] jakobhellermann/bevy-inspector-egui#185
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManevilleF ManevilleF ManevilleF approved these changes

@RobWalt RobWalt RobWalt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Aztro-dev @theshortcut @kaosat-dev @jakobhellermann @ManevilleF @RobWalt