Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minibuffer integration? #227

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

shanecelis
Copy link

Hi Jakob,

I'm a big fan of bevy-inspector-egui. I just released bevy_minibuffer, which is a gamedev console. Because I'm always reaching for bevy-inspector, I thought I'd try to integrate it with minibuffer. I've added a few posts with videos to bevy's discord #showcase: post 1 and post 2. You can play with the example:

cargo run --example minibuffer --feature minibuffer

This pull request isn't really ready to merge. I'd more like to invite a discussion as to where you think this functionality should go? The options I've considered for minibuffer integrations are these:

  1. bevy-inspector-egui adds a "minibuffer" feature flag.
  2. bevy_minibuffer adds a "bevy-inspector-egui" feature flag.
  3. A new crate with the integration is published named?
  • bevy-inspector-egui-minibuffer
  • bevy_minibuffer_inspector
  • bevy_minibuffer_inspector_egui
  • bevy_minibuffer_inspectors

This PR is currently in the mold of option 1. but I feel like there are a number of cons:

  • It introduced three new optional dependencies.
  • bevy_minibuffer is new and unstable, and bevy_inspector_egui feels kind of crucial for bevy users. It's one of the crates I want to see updated quickly when bevy releases a new minor version. I wouldn't want to delay bevy_inspector_egui's release on account of bevy_minibuffer.

Option 2. doesn't seem bad but would probably just be a stop gap before going ultimately to option 3.

So in writing this up I think I've convinced myself that option 3. is probably best. Still I'd be happy to hear what kind of "mod" crate names you'd choose for bevy_inspector_egui.

Thanks for your time.

-Shane

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant