Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace *Enum classes with a native Enums #154

Merged
merged 3 commits into from
May 24, 2024

Conversation

jeromegamez
Copy link
Contributor

interface ChannelInterface
{
-    public function getMode(): int;
+    public function getMode(): ChannelMode;
}

That's a breaking change - I don't know if this is acceptable for 0.6.x but I thought I could give it a try anyway 🤞🏻

:octocat:

@WyriHaximus WyriHaximus added this to the v0.6.0 milestone May 24, 2024
@WyriHaximus
Copy link
Collaborator

That's a breaking change - I don't know if this is acceptable for 0.6.x but I thought I could give it a try anyway 🤞🏻

I mean, this is the amount of breaking changes I made merging the sync and async client into once, breaking changes are fine in 0.6.x: #147

@WyriHaximus WyriHaximus merged commit ad5b979 into jakubkulhan:0.6.x May 24, 2024
56 checks passed
@jeromegamez jeromegamez deleted the introduce-enums branch May 24, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants