feat: enable PHP 8.1 #322
Closed
feat: enable PHP 8.1 #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for working on this. We first need to get toolbox to support PHP 8.1: jakzal/toolbox#397 |
|
@jakzal I know, I wanted to set it up here so we have something to rebase. :) |
|
Go ahead if you already have it done, no hrm done. 👌 |
|
Thanks! I forgot about nightly builds by the way. Your PR helped me :) |
|
@dkarlovi I rebased your PR after all. Thought it's good to give credit when credit is due! ;) |
|
That's nice of you, but don't make it create work for you, whichever way we get to PHP 8.1 images is awesome for me! 🍻 |
Merged
|
Ugh... looks like PHP 8.1.0 works while PHP 8.1.1 doesn't. |
|
@jakzal it's always like that. 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create the 8.1 image set.