Updates for new lints

jam1garner · Jan 6, 2024 · e96a132 · e96a132
1 parent 6507d4c
commit e96a132
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 5 deletions.
diff --git a/binrw/tests/dbg.rs b/binrw/tests/dbg.rs
@@ -3,6 +3,7 @@
 fn dbg() {
     use binrw::{io::Cursor, BinRead};
 
+    #[allow(dead_code)]
     #[derive(BinRead, Debug)]
     struct Inner(u32);
 
@@ -56,10 +57,10 @@ fn dbg() {
                     "[{file}:{offset_3} | offset 0x14] terminator = 0x69\n",
                 ),
                 file = core::file!(),
-                offset_0 = if cfg!(nightly) { 15 } else { 10 },
-                offset_1 = if cfg!(nightly) { 17 } else { 10 },
-                offset_2 = if cfg!(nightly) { 19 } else { 10 },
-                offset_3 = if cfg!(nightly) { 21 } else { 10 },
+                offset_0 = if cfg!(nightly) { 16 } else { 11 },
+                offset_1 = if cfg!(nightly) { 18 } else { 11 },
+                offset_2 = if cfg!(nightly) { 20 } else { 11 },
+                offset_3 = if cfg!(nightly) { 22 } else { 11 },
             )
         );
     }

diff --git a/binrw/tests/error.rs b/binrw/tests/error.rs
@@ -134,6 +134,7 @@ fn display() {
 fn enum_is_eol() {
     use binrw::{io::Cursor, BinRead};
 
+    #[allow(dead_code)]
     #[derive(BinRead, Debug)]
     #[br(return_all_errors)]
     enum Test {
@@ -154,6 +155,7 @@ fn enum_is_eol() {
 fn is_eof() {
     use binrw::{io::Cursor, BinRead};
 
+    #[allow(dead_code)]
     #[derive(BinRead, Debug)]
     enum A {
         A([u8; 2]),
@@ -222,6 +224,7 @@ fn no_seek_data_enum() {
         BinRead,
     };
 
+    #[allow(dead_code)]
     #[derive(BinRead, Debug)]
     enum Test {
         #[br(magic(0u8))]

diff --git a/binrw/tests/meta.rs b/binrw/tests/meta.rs
@@ -5,14 +5,17 @@ fn read_endian() {
         BinRead, Endian,
     };
 
+    #[allow(dead_code)]
     #[derive(BinRead)]
     #[br(big)]
     struct Big(u16);
 
+    #[allow(dead_code)]
     #[derive(BinRead)]
     #[br(little)]
     struct Little(u16);
 
+    #[allow(dead_code)]
     #[derive(BinRead)]
     #[br(is_little = true)]
     struct Runtime(u8);

diff --git a/binrw_derive/src/named_args/codegen.rs b/binrw_derive/src/named_args/codegen.rs
@@ -15,7 +15,7 @@ ident_str! {
 }
 
 // Lint: Describing which field name is which prevents confusion.
-#[cfg_attr(nightly, allow(clippy::struct_field_names))]
+#[allow(clippy::struct_field_names)]
 pub(super) struct Builder<'a> {
     pub(super) owner_name: Option<&'a Ident>,
     pub(super) builder_name: &'a Ident,