Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docker): add ability to specify custom paths #609

Closed
wants to merge 2 commits into from

Conversation

jamaljsr
Copy link
Owner

Description

There have been some cases where Docker or docker-compose cannot be automatically detected even when they are installed properly. This PR adds inputs to the Docker Not Detected modal to allow the user to specify the file paths to the Docker UNIX socket file or the docker-compose executable.

Screenshots

image

@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (db3be0d) compared to base (e400053).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head db3be0d differs from pull request most recent head 77b9563. Consider uploading reports for the commit 77b9563 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #609   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          116       116           
  Lines         3413      3443   +30     
  Branches       639       624   -15     
=========================================
+ Hits          3413      3443   +30     
Impacted Files Coverage Δ
src/components/common/AdvancedOptionsModal.tsx 100.00% <ø> (ø)
src/components/common/ImageUpdatesModal.tsx 100.00% <ø> (ø)
...nts/designer/bitcoind/actions/SendOnChainModal.tsx 100.00% <ø> (ø)
.../designer/lightning/actions/ChangeBackendModal.tsx 100.00% <ø> (ø)
.../designer/lightning/actions/CreateInvoiceModal.tsx 100.00% <ø> (ø)
...ts/designer/lightning/actions/OpenChannelModal.tsx 100.00% <ø> (ø)
...nts/designer/lightning/actions/PayInvoiceModal.tsx 100.00% <ø> (ø)
src/components/nodeImages/CustomImageModal.tsx 100.00% <ø> (ø)
src/components/nodeImages/ManagedImageModal.tsx 100.00% <ø> (ø)
src/components/common/StatusBadge.tsx 100.00% <100.00%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jamaljsr jamaljsr force-pushed the custom-docker-paths branch from 7291ec3 to db3be0d Compare October 15, 2022 23:13
@jamaljsr jamaljsr mentioned this pull request Oct 27, 2022
@jamaljsr
Copy link
Owner Author

Replaced by #695

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants