Skip to content
This repository has been archived by the owner on Jan 16, 2024. It is now read-only.

Feature/add jaeger base url envs #44

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Feature/add jaeger base url envs #44

wants to merge 4 commits into from

Conversation

ajukes
Copy link
Contributor

@ajukes ajukes commented Apr 6, 2023 •
edited
Loading

Added JAEGER_BASE_URL to jambonz-api-server envs in preparation for Jaeger tracing endpoint PR jambonz/jambonz-api-server#147

@ajukes ajukes mentioned this pull request Apr 6, 2023
Merged
davehorton
davehorton suggested changes Apr 10, 2023
View reviewed changes
Copy link
Contributor

@davehorton davehorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also push a change for packer/jambonz-mini/files/ecosystem.config.js to add this new env to api-server there?

      JAEGER_BASE_URL: 'http://127.0.0.1:16686'

@ajukes ajukes mentioned this pull request Apr 14, 2023
Open
@ajukes
Copy link
Contributor Author

ajukes commented Apr 14, 2023

Added more Jeager envs to cloudformation ready for @jambonz/tracing. Please checkout following PRs:

This was referenced Apr 14, 2023
Open
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@davehorton davehorton davehorton requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajukes @davehorton