Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Feature server REFER #114

Merged
merged 2 commits into from
Aug 20, 2023
Merged

Fix: Feature server REFER #114

merged 2 commits into from
Aug 20, 2023

Conversation

two56
Copy link
Contributor

@two56 two56 commented Aug 17, 2023

I meant to get this pull request in earlier and #113 reminded me to do it.

This is mostly correcting (I think) the old code. I'm returning a 488 if things go wrong.

I've tested the best I can, I getting audio!

@Megamuch
Copy link

I just tested this fix, and even though the REFER is now reported as successful, the audio is not switching.
how did you test this? also with 2 FS, 1 SIP and 1 RTP ?

@two56
Copy link
Contributor Author

two56 commented Aug 17, 2023

Two of each, but that shouldn't make a difference, having two feature servers is the important bit I think. I used two MicroSIP clients (TLS) bridged into a conference. I'll re-test and get back to you.

@Megamuch
Copy link

Megamuch commented Aug 17, 2023

okay, my use case is a bit different which may have an influence here.

Call flow is -> caller entry to queue and waits.
outbound call is done through the web api
outbound call is answered and action hook is set to a Dequeue path.
if the inbound and outbound call happen to be on different FS's, a refer will trigger to move the caller over to the callee.
without your fix, this will throw an error on the sbc-inbound (see #113).

With your fix this error is resolved, however, audio is not there.
The caller remains in the queue (unable to be popped) and the callee will get dead air with a disconnect after 30 seconds(+/-).

None of the logs throw errors and everything is reported as completed successfully.

@two56
Copy link
Contributor Author

two56 commented Aug 17, 2023

I believe it should be going through the same REFER procedure.

I've re-tested and I am getting two way audio.

@two56
Copy link
Contributor Author

two56 commented Aug 17, 2023

I've tried an enqueue, REST dial, dequeue flow and I'm getting two way audio after the REFER.

@Megamuch
Copy link

Well that's odd.
I'm running the 11.3.1.8 on ARM. (Since it was cheaper and never found an issue with it).
I'll try to get a intel 11.3.1.8 build but also the version 11.2 as a test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants