fix review comment

jambonz · Nov 13, 2023 · c4ec38b · c4ec38b
1 parent 4fec150
commit c4ec38b
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/lib/utils.js b/lib/utils.js
@@ -4,6 +4,9 @@ const debug = require('debug')('jambonz:sbc-outbound');
 const CIDRMatcher = require('cidr-matcher');
 const dns = require('dns');
 
+const cidrMatcher = process.env.PRIVATE_VOIP_NETWORK_CIDR ?
+  new CIDRMatcher(process.env.PRIVATE_VOIP_NETWORK_CIDR.split(',')) : null;
+
 function makeRtpEngineOpts(req, srcIsUsingSrtp, dstIsUsingSrtp, padCrypto, teams) {
   const from = req.getParsedHeader('from');
   const rtpCopy = JSON.parse(JSON.stringify(rtpCharacteristics));
@@ -184,7 +187,7 @@ const nudgeCallCounts = async(logger, sids, nudgeOperator, writers) => {
 };
 
 const isPrivateVoipNetwork = async(uri) => {
-  if (process.env.PRIVATE_VOIP_NETWORK_CIDR) {
+  if (cidrMatcher) {
     try {
       const arr = /sips?:.*@(.*):.*$/.exec(uri);
       if (arr) {
@@ -195,9 +198,8 @@ const isPrivateVoipNetwork = async(uri) => {
         } else {
           addresses = await dns.resolve4(input);
         }
-        const matcher = new CIDRMatcher(process.env.PRIVATE_VOIP_NETWORK_CIDR.split(','));
         for (const ip of addresses) {
-          if (matcher.contains(ip)) {
+          if (cidrMatcher.contains(ip)) {
             return true;
           }
         }