Changes to remote's and DNS firewall rules #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks it works well for Mullvad and ProtonVPN. My only concern would be for OpenVPN providers that don't provide a DNS server internal to the VPN connection and the OpenVPN hosts are given as domain names not IP addresses - so it'd need to connect to the DNS server first when creating the OpenVPN connection. But even PIA provides the DNS servers internally too now so I don't think it's a problem. And the killswitch is run after the connection is established so it should be okay, I''m sure I had some issue around this during implementation before though. |
This was referenced Jul 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #162 and #163. It is the firewall setup that I am using without any issues (with OpenVPN and IPv4 only). There is no new code as you can see. I only enabled/removed existing code. I have no idea if this would also work in general though. Maybe this shouldn't be hard coded, but controlled by options or other logic instead.