Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

Added implementation for Tizen.Net #72

Merged
merged 17 commits into from
Nov 2, 2017

Conversation

maltegoetz
Copy link

No description provided.

@lothrop
Copy link

lothrop commented Jun 1, 2017

👍

@lothrop
Copy link

lothrop commented Jun 1, 2017

I've tested this with a Tizen.NET project. It requires Nuget 4.3 to install into a Tizen project. However, that is not yet available in VS 2017. Not sure how to test if this whole thing works and we've used the right identifier in the nuspec. nuget.exe 4.3.0-preview1 only extracts the package without modifying project.json or the csproj.

@onovotny, do you have any idea how we could test this?

@clairernovotny
Copy link

I'm not sure, maybe @rrelyea knows?

@jamesmontemagno
Copy link
Owner

Hey there! This is pretty cool and interesting. I am about to make huge breaking changes for V 3 and the APIs are gunna change, so I will see what I need to do to merge it in.

@jamesmontemagno
Copy link
Owner

What tooling do I need for VS 2017?

@maltegoetz
Copy link
Author

VS 2017 is enough if you just want to compile it. If you want to try it, you need the VS tools for Tizen preview (https://developer.tizen.org/development/tizen-.net-preview/getting-started) they come with an emulator.

@jamesmontemagno
Copy link
Owner

Awesome thanks! will try it out, gunna take soem time with my new changes, will try to retarget to my other v3 branch

@jamesmontemagno jamesmontemagno changed the base branch from master to feature-filename June 1, 2017 20:47
Preference.Set(prefKey, Convert.ToString(value, System.Globalization.CultureInfo.InvariantCulture));
break;
case TypeCode.DateTime:
Preference.Set(Convert.ToString(-(Convert.ToDateTime(value)).ToUniversalTime().Ticks), prefKey);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Invalid parameter sequence.

  • Preference.Set(prefKey, Convert.ToString(-(Convert.ToDateTime(value)).ToUniversalTime().Ticks));

if (value == null)
value = Guid.Empty;

Preference.Set(((Guid)value).ToString(), prefKey);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Invalid parameter sequence.

  • Preference.Set(prefKey, ((Guid)value).ToString());

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JongHeonChoi
Copy link

JongHeonChoi commented Jul 19, 2017

src/Plugin.Settings.Tizen/Settings.cs
Invalid parameter sequence.
151 line => Preference.Set(prefKey, Convert.ToString(-(Convert.ToDateTime(value)).ToUniversalTime().Ticks));
159 line => Preference.Set(prefKey, ((Guid)value).ToString());

@clairernovotny
Copy link

clairernovotny commented Jul 19, 2017

@jamesmontemagno @maltegoetz if you convert this to csproj, you can now build the tizen30 and tizen40 TFM if you include my MSBuild.Sdk.Extras package.

Instructions are here https://github.com/onovotny/MSBuildSdkExtras#targeting-tizen

This work much more cleanly than project.json. All uses of project.json should be removed since it's buggy.

@jamesmontemagno
Copy link
Owner

Is it possible yet for the nuget support for Tizen?

@clairernovotny
Copy link

yes, tizen30 and tizen40 are valid TFM's and my MSBuild.Sdk.Extras project lets you multi-target to them in an SDK style project.

@lothrop
Copy link

lothrop commented Oct 30, 2017

I’ll schedule working on this. Will AppVeyor be able to build it?

@clairernovotny
Copy link

Should be since Tizen is basically .NET Standard 1.6 plus their libraries. Last I checked, there's no local tooling to install.

@jamesmontemagno
Copy link
Owner

Yeah good question about appveyor... probably not i guess....

@clairernovotny
Copy link

@jamesmontemagno AppVeyor should work. no special tooling is required, it's just library/nuget references.

@lothrop
Copy link

lothrop commented Oct 30, 2017

@onovotny I'm not sure if I should be targeting tizen30 or tizen40. The Nuget package Tizen.NET seemed to be only available as 3.0.0.

@lothrop
Copy link

lothrop commented Oct 30, 2017

All set to merge.

@clairernovotny
Copy link

Why are you using a nuspec and not msbuld /t:pack with an SDK style project?

@clairernovotny
Copy link

I guess converting to SDK style projects could be a separate PR -- but these can all be one project with multi-targeting:
image

@jamesmontemagno
Copy link
Owner

@onovotny I don't want to use any of that new stuff, I haven't had time to actually learn all that. This works and I like to be explicit.

I also don't want to use multi-targeting at all and want them separate :)

@jamesmontemagno jamesmontemagno changed the base branch from feature-filename to master November 2, 2017 14:30
@jamesmontemagno jamesmontemagno changed the base branch from master to feature-tizen November 2, 2017 14:31
@jamesmontemagno jamesmontemagno merged commit 8e7a5c8 into jamesmontemagno:feature-tizen Nov 2, 2017
@ghost ghost removed the in-progress label Nov 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants