Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated componentWillMount to componentDidMount #220

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Updated componentWillMount to componentDidMount #220

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18de9a4
Updated componentWillMount to componentDidMount
Daggron Dec 17, 2019
9960390
chnaged back to component will unmount
Daggron Jan 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ function createLoadableComponent(loadFn, options) {
return init();
}

componentWillMount() {
componentDidMount() {
this._mounted = true;
this._loadModule();
}
Expand Down Expand Up @@ -213,7 +213,7 @@ function createLoadableComponent(loadFn, options) {
});
}

componentWillUnmount() {
componentDidUnmount() {
Copy link

@pixmaster pixmaster Jan 10, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I understand, componentWillUnmount wasn't deprecated, only componentWillMount.

BTW componentDidUnmount non-existent method

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay , Sir I will change it

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sir i have changed the method back to componentWillUnmount

this._mounted = false;
this._clearTimeouts();
}
Expand Down