Allow raw parameter to accept callable like body elements
#233
Conversation
| @@ -70,6 +70,9 @@ Dynamic Response | |||
| ================ | |||
|
|
|||
| A callback can be provided in place of any of the body elements. | |||
| raw attribute also accepts callable that returns HTTPResponse. | |||
| The HTTPResponse should have `preload_content=False` or it may not work properly. | |||
There was a problem hiding this comment.
does it make sense to just always set raw.preload_content = False on the raw object? I forget what would happen if this isn't set?
There was a problem hiding this comment.
enforce_content_length = False should probably always be set as well?
There was a problem hiding this comment.
I think we leave them as is to avoid breaking backward compatibility.
There was a problem hiding this comment.
ok, so i can't set preload_content as that is acted upon in the constructor. Setting it afterwards has no impact.
For enforce_content_length i think it should probably be false - but the whole point of using raw is that the user provides this HTTPResponse object so i guess we shouldn't do anything that changes the values they set.
| @@ -70,6 +70,9 @@ Dynamic Response | |||
| ================ | |||
|
|
|||
| A callback can be provided in place of any of the body elements. | |||
| raw attribute also accepts callable that returns HTTPResponse. | |||
| The HTTPResponse should have `preload_content=False` or it may not work properly. | |||
There was a problem hiding this comment.
ok, so i can't set preload_content as that is acted upon in the constructor. Setting it afterwards has no impact.
For enforce_content_length i think it should probably be false - but the whole point of using raw is that the user provides this HTTPResponse object so i guess we shouldn't do anything that changes the values they set.
| encoding = get_encoding_from_headers(headers) or 'utf-8' | ||
| content = text.encode(encoding) | ||
| if content is not None: | ||
| body = _IOReader(content) |
There was a problem hiding this comment.
It's not right or wrong - but I don't want to change this block for this purpose.
The whole logic here kind of falls through to the next step based on what's been set and whilst we could reorganize it a little for efficiency it's true for all these statements, not just raw.
Unless i'm missing something please revert this bit.
|
I will not be able to do more work for this feature. partially because I've since moved to other projects that don't need this feature and partially because I forgot the code. The pull request is yours, please do with it what you see fit. |
|
I understand it's pretty old. Thanks for letting me know and I'll pick it up. Apologies again for the delay. |
|
of course no need for apology. |
|
Moved to #249 as i can't push to your master branch. |
No description provided.