Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type hint of Mocker.__enter__/__exit__ #257

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

Viicos
Copy link
Contributor

@Viicos Viicos commented Apr 5, 2024

No description provided.

@jamielennox
Copy link
Owner

Thank you, checked this compared to the search on the internet. A bit weird that you can't do this in a more supported way, but sure.

@jamielennox jamielennox merged commit c42ab56 into jamielennox:master Apr 18, 2024
6 checks passed
@Viicos Viicos deleted the fix-ctx-manager-types branch April 18, 2024 15:15
@Viicos
Copy link
Contributor Author

Viicos commented Apr 18, 2024

Thank you, checked this compared to the search on the internet. A bit weird that you can't do this in a more supported way, but sure.

I agree it's a bit verbose. As a side note:

@jamielennox
Copy link
Owner

Oh, I didn't even register the external import as it all seemed to work. I only recently dropped py2 support, now I should merge all these type definitions back into the regular code base and it will make gaps like this a lot more obvious.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants