Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promise polyfill required as of v1.3.0 #341

Closed
techfg opened this issue Jan 21, 2021 · 0 comments · Fixed by #342
Closed

Promise polyfill required as of v1.3.0 #341

techfg opened this issue Jan 21, 2021 · 0 comments · Fixed by #342

Comments

@techfg
Copy link
Collaborator

techfg commented Jan 21, 2021

Describe the bug
The changes introduced to support UMD in #314 broke compatibility with ES5 as ES5 does not support native Promises. While the majority of targeted devices/browers now support ES6 (which includes Promises), this is a breaking change and IM should provide a path to support ES5.

When IM is refactored/rewritten to ES6 module, a transpiler will eliminate the requirement for a separate dependency to be loaded. For now, if IM needs to be used in an ES5 environment, a Promise polyfill is required to be loaded.

To Reproduce
Steps to reproduce the behavior:

  1. Open USA example in non-ES6 browser (e.g. IE 11)
  2. Exception encountered: SCRIPT5009: 'Promise' is undefined

Expected behavior
IM should work in ES5 devices/browsers.

Screenshots
N/A

Desktop (please complete the following information):
N/A

Smartphone (please complete the following information):
N/A

Additional context
N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant