Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resize callback not working #87

Closed
qwertzy opened this issue Sep 28, 2012 · 5 comments
Closed

resize callback not working #87

qwertzy opened this issue Sep 28, 2012 · 5 comments
Labels

Comments

@qwertzy
Copy link

qwertzy commented Sep 28, 2012

I'm trying to get feedback once the resize animation has finished. But the callback function is not working. It's either duration or undefined.
Is there a way to receive an event once the resize animation is done?

@jamietre
Copy link
Owner

jamietre commented Oct 1, 2012

Confirmed; i'll get a fix for this sometime today. I'm nearly ready to release 1.2.7 so this will get into that release too.

This isn't actually part of the documented API, but it used to work. I had begun work a while ago on a more consistent API that uses a promise model for async callbacks but other priorities got in the way so I never finished it. It's easy enough to make this work right for now though.

@qwertzy
Copy link
Author

qwertzy commented Oct 1, 2012

nice! Thank you

@qwertzy qwertzy closed this as completed Oct 1, 2012
@qwertzy
Copy link
Author

qwertzy commented Oct 5, 2012

ah sorry I just saw that I already closed the bug. I'll leave it open until its really fixed

@qwertzy qwertzy reopened this Oct 5, 2012
@jamietre
Copy link
Owner

jamietre commented Oct 5, 2012

I didn't forget - just had too much to do this week to get to it! But leaving it open better anyway. I should have time this weekend to catch up.

jamietre pushed a commit that referenced this issue Nov 1, 2012
@jamietre
Copy link
Owner

jamietre commented Nov 1, 2012

Fixed in last push (1.2.6.100) - Sorry for the long delay!

@jamietre jamietre closed this as completed Nov 1, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants