Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postgres Option to Return Primary Keys #32

Merged
merged 17 commits into from
Jun 27, 2018

Conversation

ploomiz
Copy link
Contributor

@ploomiz ploomiz commented Mar 30, 2018

PostgreSQL has a RETURNING clause that allows INSERT statements to return primary keys of inserted records.

These changes allow the bulk insert worker to store primary keys of inserted records if the option to return primary keys is given and the user uses Postgres or PostGIS.

@ploomiz ploomiz closed this Mar 30, 2018
@ploomiz ploomiz deleted the postgres_option_to_return_ids branch March 30, 2018 20:55
@ploomiz ploomiz restored the postgres_option_to_return_ids branch March 30, 2018 20:56
@ploomiz ploomiz reopened this Mar 30, 2018
@ploomiz ploomiz force-pushed the postgres_option_to_return_ids branch from da4f9d5 to 4dba698 Compare March 30, 2018 21:25
@ploomiz
Copy link
Contributor Author

ploomiz commented Apr 21, 2018

@jamis requesting your review please

@pedrocunha
Copy link

This would be a great addition to the gem. Are we considering merging this in the near future? Thanks

@jamis jamis merged commit 6ef4d59 into jamis:master Jun 27, 2018
@jamis
Copy link
Owner

jamis commented Jun 27, 2018

Thank you so much, @psloomis! I'm sorry I sat on this one so long. I'm working through PR's this morning and will try to have a new version released today.

@ploomiz ploomiz deleted the postgres_option_to_return_ids branch June 27, 2018 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants