-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Postgres Option to Return Primary Keys #32
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify worker query to return ids of inserted records
ploomiz
force-pushed
the
postgres_option_to_return_ids
branch
from
March 30, 2018 21:25
da4f9d5
to
4dba698
Compare
@jamis requesting your review please |
This would be a great addition to the gem. Are we considering merging this in the near future? Thanks |
Thank you so much, @psloomis! I'm sorry I sat on this one so long. I'm working through PR's this morning and will try to have a new version released today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PostgreSQL has a
RETURNING
clause that allowsINSERT
statements to return primary keys of inserted records.These changes allow the bulk insert worker to store primary keys of inserted records if the option to return primary keys is given and the user uses Postgres or PostGIS.