Support SDWebImage both v3 and v4 #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewhavens
requested changes
Dec 8, 2017
| @@ -63,10 +63,10 @@ def set_remote_image | |||
| self.imageView.image = remote_placeholder | |||
|
|
|||
| if sd_web_image? | |||
| @remote_image_operation = SDWebImageManager.sharedManager.downloadWithURL(data_cell[:remote_image][:url].to_url, | |||
| options:SDWebImageRefreshCached, | |||
| @remote_image_operation = SDWebImageManager.sharedManager.loadImageWithURL(data_cell[:remote_image][:url].to_url, | |||
There was a problem hiding this comment.
This change will break for anyone who is still using v3. You could change this to support both v3 and v4 by checking to see if the method exists before calling it, like this:
if SDWebImageManager.sharedManager.respond_to?('downloadWithURL:options:progress:completed')
# old v3 code here
else
# new v4 code here
end
|
Thanks for your work on this @Lax! If you could make that simple change to support both v3 and v4 that I mentioned above, I will merge it. |
andrewhavens
approved these changes
Dec 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See "SDWebImage 4.0 Migration Guide"