Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NSHipster.com to List of Examples #138

Closed
wants to merge 3 commits into from
Closed

Add NSHipster.com to List of Examples #138

wants to merge 3 commits into from

Conversation

mattt
Copy link

@mattt mattt commented Nov 1, 2018

nshipster-jamstack-screenshot

@mattt
Copy link
Author

mattt commented Nov 1, 2018

Checks are failing, but it doesn't look like it was caused by this commit in particular.

Here's what I got when running a fresh clone of the repository (node v8.10.0, npm 6.4.1):

$ npm run start
fnm: It seems 'node' is not a valid version number.
Hint: Examples of valid node versions:
       v5.10.1
        latest
          0.12
           lts

> victor-hugo@1.0.0 start /Users/mattt/Sites/jamstack.org
> gulp server

[11:12:51] Failed to load external module @babel/register
[11:12:51] Requiring external module babel-register
...

@mattt
Copy link
Author

mattt commented Nov 1, 2018

9990fad fixed the "It seems 'node' is not a valid version number." error, but checks are still failing on 11:26:47 AM: > gulp build-preview.

@mattt
Copy link
Author

mattt commented Nov 1, 2018

I just realized that I was previewing locally with gulp server instead of gulp build, so I was confused why it was succeeding locally but failing on deploy. I can now replicate the issue locally.

This appears to be related to gulpjs/gulp#2246. It looks like our options are to either upgrade to gulp@next to support new Node versions or specify an older version of node to a version compatible with 3.9.1.

@netlify
Copy link

netlify bot commented Nov 1, 2018

Deploy preview for jamstack-site ready!

Built with commit c6043f8

https://deploy-preview-138--jamstack-site.netlify.com

@mattt
Copy link
Author

mattt commented Nov 1, 2018

Alright, I updated to Gulp 4 with c6043f8. This required some slight modifications to gulpfile.babel.js to migrate to the new task API (instead of an array of dependencies, you specify gulp.series(...) or gulp.parallel(...)).

@philhawksworth
Copy link
Member

Closed by #285

@mattt
Copy link
Author

mattt commented Mar 19, 2020

Awesome. Thanks so much, @philhawksworth!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants