Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimising the code by fixing var-declaration, indent-error-flow, increment-decrement, superfluous-else #1

Merged
merged 2 commits into from
Aug 18, 2024

Conversation

janardhanvissa
Copy link
Owner

@janardhanvissa janardhanvissa commented Aug 14, 2024

grpc#7444 Fixed below linter issues

Description:
6 var-declaration
3 indent-error-flow
2 increment-decrement
1 superfluous-else

RELEASE NOTE: NA

@janardhanvissa janardhanvissa mentioned this pull request Aug 14, 2024
13 tasks
@purnesh42H
Copy link

can you update the description in this form grpc#7472 (review) for what you have fixed in this PR?

@janardhanvissa janardhanvissa changed the title Fixed linter issues for superfluous-else, increment-decrement, indent… Optimising the code and adding docstring Aug 16, 2024
@janardhanvissa janardhanvissa changed the title Optimising the code and adding docstring Optimising the code by fixing var-declaration, indent-error-flow, increment-decrement, superfluous-else Aug 16, 2024
@janardhanvissa
Copy link
Owner Author

@purnesh42H Updated the description and optimizing the code by fixing var-declaration, indent-error-flow,
increment-decrement, superfluous-else

@janardhanvissa janardhanvissa self-assigned this Aug 16, 2024
@purnesh42H
Copy link

Thanks @janardhanvissa please open the PR with the same description. Also, against each lint type, put the number of occurences being fixed like below

6 var-declaration
3 indent-error-flow
2 increment-decrement
1 context-as-argument
1 superfluous-else

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants