Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix LH and LF calculation #4

Merged
merged 1 commit into from
Apr 26, 2020
Merged

fix LH and LF calculation #4

merged 1 commit into from
Apr 26, 2020

Conversation

jandelgado
Copy link
Owner

The values for

 LH:<number of lines with a non-zero execution count>
 LF :<number of instrumented lines>

were calculated incorrectly,leading to wrong coverage reports.

@jandelgado jandelgado mentioned this pull request Apr 25, 2020
Closed
@arvenil arvenil mentioned this pull request Apr 26, 2020
Merged
@arvenil
Copy link

arvenil commented Apr 26, 2020

With jandelgado/gcov2lcov-action@c760baa
arvenil_kata__Playground_for_Kata_形🤺_exercises_by__pragdave_
Looks good now. codecov 69% vs coveralls 74%.

Thanks!

@jandelgado jandelgado merged commit 01d5e75 into master Apr 26, 2020
@jandelgado jandelgado deleted the fix_lh_and_lf_calculation branch April 26, 2020 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jandelgado @arvenil