Fixed typography on FullScreenMessage component #50
+10
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablonortiz
requested review from
colomfernando,
christian97dd,
pablodamianberdun and
GonzaFran
GonzaFran
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LINK DE TICKET: *
https://janiscommerce.atlassian.net/browse/JUIP-165
DESCRIPCIÓN DEL REQUERIMIENTO: *
Se requiere corregir la tipografía del componente FullScreenMessage para que quede según diseño
DESCRIPCIÓN DE LA SOLUCIÓN: *
Se añadieron las props type y size para los dos componentes Typography que se emplearon dentro del componente FullScreenMessage para que los mismos sean iguales a los que se usaron en el diseño
CÓMO SE PUEDE PROBAR? *
Verificando que la tipografía sea la misma que la del diseño
SCREENSHOTS:
Antes:
Después:
DATOS EXTRA A TENER EN CUENTA: