Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw Error instances instead of strings #12

Merged
merged 2 commits into from
Feb 12, 2015
Merged

Throw Error instances instead of strings #12

merged 2 commits into from
Feb 12, 2015

Conversation

marcbachmann
Copy link
Collaborator

Requested in issue #11
There are no tests against .get calls that would result in an error. Do you need some?

@marcbachmann
Copy link
Collaborator Author

Apparently node v0.4 isn't available anymore on travis. nvm install 0.4 fails on there.

janl added a commit that referenced this pull request Feb 12, 2015
Throw Error instances instead of strings
@janl janl merged commit c7698a0 into janl:master Feb 12, 2015
@janl
Copy link
Owner

janl commented Feb 12, 2015

perfect, thanks, sorry for the delay!

@marcbachmann fancy becoming a contributor here?

@marcbachmann
Copy link
Collaborator Author

No problem. I'm not in a hurry.
Yes, that's ok for me.

@janl
Copy link
Owner

janl commented Feb 12, 2015

cool, welcome aboard ;)

@marcbachmann
Copy link
Collaborator Author

@janl That change is still not published on npm. Can you add me there please. I currently can't publish.
Besides, this is a breaking API change, so I'll create a 2.0.0 release. If you agree with that. 😄

@janl
Copy link
Owner

janl commented May 23, 2015

@marcbachmann added you to the jsonpointer npm owners. Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants