Better on mobile and better about which option is active #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gOptions replace setOptionsVisible(bool) with open_dropdown() and close_dropdown() trigger close_dropdown() on touchstart outside (as well as click outside), select wasn't closing on mobile without that rename prop showOptions to open add props focusInputOnSelect: boolean | 'desktop' and breakpoint = 800
until sveltejs/kit#6462 resolves static > Using @sveltejs/adapter-static fails with error @sveltejs/adapter-static: all routes must be fully prerenderable (unless using the 'fallback' option — see https://github.com/sveltejs/kit/tree/master/packages/adapter-static#spa-mode). Try adding `export const prerender = true` to your root layout — see https://kit.svelte.dev/docs/page-options#prerender for more details run CI tests on both linux and windows using matrix strategy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
matchingOptions. Before identical options would all become active simultaneously when hovering any one of them.setOptionsVisible(bool)withopen_dropdown()andclose_dropdown()close_dropdown()on:touchstartoutsideouterDiv(as well ason:clickoutside), Multiselect wasn't closing on mobile without thatshowOptionstoopenfocusInputOnSelect: boolean | 'desktop' = 'desktop'andbreakpoint = 800